Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[AOL] Removed exclusion for nonexistent URL, added... - #4495

Closed
galenide wants to merge 2 commits into
EFForg:masterfrom
galenide:improved-aol-ruleset
Closed

galenide wants to merge 2 commits into
EFForg:masterfrom
galenide:improved-aol-ruleset

Conversation

@galenide

Copy link
Copy Markdown
Contributor

…the notifications.mail.aol.com target host, and secured cookies for certain domains.

…mail.aol.com target host, and secured cookies for certain domains.
<exclusion pattern="^http://my\.screenname\.aol\.com/_cqr/logout/" />

<test url="http://my.screenname.aol.com/_cqr/logout/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel a bit uncomfortable with that, since it was added by the AOL team itself (see d6df8ba).

@galenide galenide Apr 7, 2016 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0WI Right now, it appears that the URL http://my.screenname.aol.com/_cqr/logout/ leads to a 404 response error page with a message about "They page you are looking for might have been removed." This error page is encountered regardless of whether the URL is accessed via HTTP or HTTPS. It is possible that the URL was functional in the past and that the URLs for logging out of the AOL service have changed over time. (It might be possible for the URL to become functional in the future, but that does not seem to be necessarily likely.)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, the specified exclusion pattern defines just the root of URLs to be excluded. If you do an HTTP Trace on a logout of www.aol.com, it will actually invoke http://my.screenname.aol.com/_cqr/logout/mcLogout.psp with some query parameters. I don't work on the application at AOL anymore, but I did confirm with the developers that this is still needed. Thanks!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, that is true too. account.login.aol.com moved to i.aol.com.

@galenide

Copy link
Copy Markdown
Contributor Author

@J0WI @fuglede Would it be possible to confer with AOL and find out if the exclusion for http://my.screenname.aol.com/_cqr/logout/ is still necessary? (From what one can tell, when a user is signed into AOL Mail, accessing the URL gives an error page and does not log out the user.) If the exclusion is no longer necessary, it would be possible to improve the ruleset by doing such things as securing all cookies for the my.screenname.aol.com domain.

@J0WI

J0WI commented May 30, 2016

Copy link
Copy Markdown
Contributor

Since @gleeworks is no longer active I think I'm okay with the fact that this domain seems to be useless now.
Let me just rerun the test before I merge.

@J0WI J0WI closed this May 30, 2016
@J0WI J0WI reopened this May 30, 2016
@J0WI

J0WI commented May 30, 2016

Copy link
Copy Markdown
Contributor

Okay, now we have a mismatch. @galenide could you have a look?

@gleeworks

Copy link
Copy Markdown

I just got email notification about this ticket yesterday from the mention of my userid. I don't work on the application anymore, but I confirmed with the AOL developer that the exclusion pattern is still needed for logout. As I remember correctly, the specified exclusion pattern defines just the root of the URL to be excluded, which should apply to the actual non-SSL Logout URL (e.g., http://my.screenname.aol.com/_cqr/logout/mcLogout.psp with some query parameters). Thanks!

@J0WI

J0WI commented Aug 21, 2016

Copy link
Copy Markdown
Contributor

Just pinging @galenide to make sure you are aware of #4495 (comment)

@jeremyn

jeremyn commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

@galenide I'm not sure what the status is here, is this ready for review?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants